[PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
From: Raja, Govindraj <hidden>
Date: 2012-04-16 10:05:38
Also in:
linux-omap
On Fri, Apr 13, 2012 at 11:25 PM, Santosh Shilimkar [off-list ref] wrote:
The current serial UART code, while fidling with ocp idlemode bits, forget about the smart idle wakeup bit even if it is supported by UART IP block. This will lead to missing the module wakeup on OMAP's where the smart idle wakeup is supported. This was the root cause of the console sluggishness issue, I have been observing on OMAP4 devices and also can be potential reason for some other UART wakeup issues. Signed-off-by: Santosh Shilimkar <redacted> Cc: Govindraj.R <redacted>
Acked-by: Govindraj.R <redacted> Adding to git://gitorious.org/linux-3-x/omap-serial.git for_3.4/uart_fixes
quoted hunk ↗ jump to hunk
Cc: Kevin Hilman <redacted> Cc: Paul Walmsley <paul@pwsan.com> --- ?arch/arm/mach-omap2/serial.c | ? ?8 +++++++- ?1 files changed, 7 insertions(+), 1 deletions(-)diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index c9503a7..b28aae1 100644 --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c@@ -108,8 +108,14 @@ static void omap_uart_set_noidle(struct platform_device *pdev)?static void omap_uart_set_smartidle(struct platform_device *pdev) ?{ ? ? ? ?struct omap_device *od = to_omap_device(pdev); + ? ? ? u8 idlemode; - ? ? ? omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_SMART); + ? ? ? if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP) + ? ? ? ? ? ? ? idlemode = HWMOD_IDLEMODE_SMART_WKUP; + ? ? ? else + ? ? ? ? ? ? ? idlemode = HWMOD_IDLEMODE_SMART; + + ? ? ? omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode); ?} ?#else -- 1.7.5.4