Thread (4 messages) 4 messages, 4 authors, 2012-04-15
STALE5207d REVIEWED: 4 (4M)

[PATCH] ARM: OMAP: clock: cleanup CPUfreq leftovers, fix build errors

From: paul@pwsan.com (Paul Walmsley)
Date: 2012-04-13 22:38:59
Also in: linux-omap

On Fri, 13 Apr 2012, Kevin Hilman wrote:
Now that we have OPP layer, and OMAP CPUfreq driver is using it, we no
longer need/use the clock framework code for filling up CPUfreq
tables.  Remove it.

Removing this code also eliminates build errors when CPU_FREQ_TABLE
support is not enabled.

Thanks to Russell King for pointing out the parts I missed under
plat-omap in the original version and also pointing out the build
errors when CPUFREQ_TABLE support was not enabled.

Cc: Russell King <redacted>
Signed-off-by: Kevin Hilman <redacted>
---
Tony/Paul, can you queue this up ASAP for v3.4-rc?  This was a cleanup
that was targetted to go in to v3.4, but missed the merge window.  The
cleanup is still needed, but now it's also a fix since this dead code
also causes build errors when CPU_FREQ_TABLE support is not enabled.

Also, if we don't merge this patch, we'll have to rework it because
Russell has queued an alternate fix to this which changes some of this
code that should be removed instead:
http://marc.info/?l=linux-arm-kernel&m=133434335009356&w=2
However, if we get this fix in soon, Russell is willing to drop his 
version.   

 arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c |   80 --------------------------
 arch/arm/mach-omap2/clock.c                  |    5 --
 arch/arm/mach-omap2/clock.h                  |    8 ---
 arch/arm/plat-omap/clock.c                   |   26 ---------
 arch/arm/plat-omap/include/plat/clock.h      |   10 ----
Acked-by: Paul Walmsley <paul@pwsan.com>


- Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help