[PATCH v5 09/16] pwm: tegra: Add device tree support

* Stephen Warren wrote:

On 04/02/2012 02:37 AM, Thierry Reding wrote:

quoted

* Stephen Warren wrote:

quoted

On 03/28/2012 08:33 AM, Thierry Reding wrote:

quoted

Add auxdata to instantiate the PWFM controller from a device tree,
include the corresponding nodes in the dtsi files for Tegra 20 and
Tegra 30 and add binding documentation.

Signed-off-by: Thierry Reding <redacted>
Acked-by: Stephen Warren <redacted>

quoted

diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c

...

quoted

+#ifdef CONFIG_OF
+static struct of_device_id tegra_pwm_of_match[] = {
+	{ .compatible = "nvidia,tegra20-pwm" },
+	{ .compatible = "nvidia,tegra30-pwm" },

Could you swap those two lines, so that tegra30-pwm matches first. It
makes no difference at present, but might in the future if the driver
actually has to differentiate the two SoCs.

I thought the matching order was determined by the compatible property in the
device tree, not the OF match table of the driver.

At least logically, yes. However, of_match_device() appears to iterate
over each match table entry, checking whether it matches any string in
the compatible flag. Perhaps this could be considered a bug?

It certainly is counter-intuitive. Maybe Grant or Rob can comment?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120403/ecd4b896/attachment.sig>