Thread (1 message) 1 message, 1 author, 2012-04-02

[PATCH v5 09/16] pwm: tegra: Add device tree support

From: Thierry Reding <hidden>
Date: 2012-04-02 08:37:49
Also in: linux-devicetree, linux-tegra

* Stephen Warren wrote:
On 03/28/2012 08:33 AM, Thierry Reding wrote:
quoted
Add auxdata to instantiate the PWFM controller from a device tree,
include the corresponding nodes in the dtsi files for Tegra 20 and
Tegra 30 and add binding documentation.

Signed-off-by: Thierry Reding <redacted>
Acked-by: Stephen Warren <redacted>
quoted
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
...
quoted
+#ifdef CONFIG_OF
+static struct of_device_id tegra_pwm_of_match[] = {
+	{ .compatible = "nvidia,tegra20-pwm" },
+	{ .compatible = "nvidia,tegra30-pwm" },
Could you swap those two lines, so that tegra30-pwm matches first. It
makes no difference at present, but might in the future if the driver
actually has to differentiate the two SoCs.
I thought the matching order was determined by the compatible property in the
device tree, not the OF match table of the driver.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120402/066b6c5d/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help