Thread (1 message) 1 message, 1 author, 2012-03-22
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH] watchdog/coh901327: convert to use watchdog core

From: Linus Walleij <hidden>
Date: 2012-03-22 18:09:15
Also in: linux-watchdog

On Thu, Mar 22, 2012 at 3:49 PM, Wim Van Sebroeck [off-list ref] wrote:
I added it. Only issue left is that you don't set the timeout value properly.
This will result in faulty values for the WDIOC_GETTIMEOUT iotcl.
Furthermore margin should be unsigned int. And there is also no check to see
if margin is a valid parameter after it is loaded as a module.

Could you test attached patch?
I cannot test it right now because I'm out of reach for the hardware,
but it looks good to me so:
Acked-by: Linus Walleij <redacted>

If I find any problems later I can surely fix them.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help