Thread (10 messages) 10 messages, 3 authors, 2012-03-28
STALE5197d
Revisions (5)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 current
  4. v1 [diff vs current]
  5. v1 [diff vs current]

[PATCH 1/3] mmc: atmel-mci: correct data timeout computation

From: Ludovic Desroches <hidden>
Date: 2012-03-22 08:57:37
Also in: linux-mmc

Hello Sergei,

On Wed, Mar 21, 2012 at 07:26:04PM +0300, Sergei Shtylyov wrote:
Hello.

On 03/21/2012 06:41 PM, ludovic.desroches at atmel.com wrote:
quoted
From: Ludovic Desroches<redacted>
quoted
The HSMCI operates at a rate of up to Master Clock divided by two.
quoted
Signed-off-by: Ludovic Desroches<redacted>
---
 drivers/mmc/host/atmel-mci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
quoted
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index e4449a5..e161452 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -480,7 +480,7 @@ err:
 static inline unsigned int atmci_ns_to_clocks(struct atmel_mci *host,
 					unsigned int ns)
 {
-	return (ns * (host->bus_hz / 1000000) + 999) / 1000;
+	return (ns * ((host->bus_hz/2) / 1000000) + 999) / 1000;
   Why don't you keep the notation by addign spaces around '/'?
   BTW, could use DIV_ROUND_UP() here.
Thanks for your comments. BTW I have realized (when testing values return using
DIV_ROUND_UP) that I may have another issue with this timeout calculation.
I will send a new patch.

Regards

Ludovic
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help