Thread (7 messages) 7 messages, 4 authors, 2012-03-22
STALE5205d

[PATCH v3] serial: PL011: clear pending interrupts

From: viresh kumar <hidden>
Date: 2012-03-21 11:58:27
Also in: linux-serial

On Tue, Mar 13, 2012 at 5:57 PM, Linus Walleij
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
@@ -1927,6 +1930,10 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
? ? ? ? ? ? ? ?goto unmap;
? ? ? ?}

+ ? ? ? /* Ensure interrupts from this UART are masked and cleared */
+ ? ? ? writew(0, uap->port.membase + UART011_IMSC);
+ ? ? ? writew(0xffff, uap->port.membase + UART011_ICR);
+

Hey Linus,

I was working on v3.3 and found a crash for my SoC. When i checked i got a crash
due to above changes.

There are two issues here
 - uap->port is uninitialized
 - clk is not enabled.

How is this working for you?

--
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help