Thread (5 messages) read the whole thread 5 messages, 4 authors, 2012-03-13
STALE5253d REVIEWED: 3 (3M)

1 review trailer.

[PATCH v4 04/11] ep93xx: Use ioremap for backlight driver

From: H Hartley Sweeten <hidden>
Date: 2012-03-13 16:49:54

On Monday, March 12, 2012 3:48 PM, Ryan Mallon wrote:
The ep93xx backlight driver uses a single register within the
framebuffer's register space. Currently the backlight driver uses a
static IO mapping for the register since the memory cannot be
requested by both drivers.

Convert the static mapping to use ioremap so that we can remove the
dependency on mach/hardware.h. To do so, we need remove the
request_mem_region from both the backlight and framebuffer drivers,
since whichever driver is loaded second will fail with -EBUSY
otherwise.

A proper fix is still required, and a FIXME comment has been added to
both drivers.

Signed-off-by: Ryan Mallon <redacted>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mika Westerberg <redacted>
Cc: Richard Purdie <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
 arch/arm/mach-ep93xx/core.c         |   10 ++++++++++
 drivers/video/backlight/ep93xx_bl.c |   25 ++++++++++++++-----------
 drivers/video/ep93xx-fb.c           |   15 +++++++++------
 3 files changed, 33 insertions(+), 17 deletions(-)
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help