From: Kevin Hilman <hidden> Date: 2012-03-12 18:54:32
Tarun Kanti DebBarma [off-list ref] writes:
The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
as we already have them as part of bank->context now. Also, remove un-used
variable from gpio_irq_handler.
The fixes include correction of _set_gpio_irqenable() implementation,
missing wakeup_en register update in set_gpio_wakeup(), type mismatch
of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
register update in set_gpio_dataout_() and few corrections in context
save logic.
It is baselined on top of Kevin's following series:
gpio/omap: cleanup and runtime PM conversion for v3.4
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/gpio/runtime-pm-cleanup
Series is available here for reference:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev for_3.4/gpio_further_cleanup_fixes
From: DebBarma, Tarun Kanti <hidden> Date: 2012-03-12 19:53:45
On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman [off-list ref] wrote:
Tarun Kanti DebBarma [off-list ref] writes:
quoted
The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
as we already have them as part of bank->context now. Also, remove un-used
variable from gpio_irq_handler.
The fixes include correction of _set_gpio_irqenable() implementation,
missing wakeup_en register update in set_gpio_wakeup(), type mismatch
of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
register update in set_gpio_dataout_() and few corrections in context
save logic.
It is baselined on top of Kevin's following series:
gpio/omap: cleanup and runtime PM conversion for v3.4
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/gpio/runtime-pm-cleanup
Series is available here for reference:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev for_3.4/gpio_further_cleanup_fixes
This branch doesn't exist.
Oops... I am sorry.
I was in the process of updating the branch with latest comments after
base-lining on Grant's:
git://git.secretlab.ca/git/linux-2.6.git
Branch: gpio/next
Because this has all the gpio changes including Benoit's latest gpio
devicetree changes.
Should I go ahead?
--
Tarun
From: DebBarma, Tarun Kanti <hidden> Date: 2012-03-12 20:08:41
On Tue, Mar 13, 2012 at 1:23 AM, DebBarma, Tarun Kanti
[off-list ref] wrote:
On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman [off-list ref] wrote:
quoted
Tarun Kanti DebBarma [off-list ref] writes:
quoted
The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
as we already have them as part of bank->context now. Also, remove un-used
variable from gpio_irq_handler.
The fixes include correction of _set_gpio_irqenable() implementation,
missing wakeup_en register update in set_gpio_wakeup(), type mismatch
of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
register update in set_gpio_dataout_() and few corrections in context
save logic.
It is baselined on top of Kevin's following series:
gpio/omap: cleanup and runtime PM conversion for v3.4
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/gpio/runtime-pm-cleanup
Series is available here for reference:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev for_3.4/gpio_further_cleanup_fixes
This branch doesn't exist.
Oops... I am sorry.
I was in the process of updating the branch with latest comments after
base-lining on Grant's:
git://git.secretlab.ca/git/linux-2.6.git
Branch: gpio/next
Because this has all the gpio changes including Benoit's latest gpio
devicetree changes.
Should I go ahead?
Anyways, for the time being I am updating on top of your changes as before.
You should be able to see the branch shortly.
--
Tarun
From: DebBarma, Tarun Kanti <hidden> Date: 2012-03-12 20:27:03
On Tue, Mar 13, 2012 at 1:38 AM, DebBarma, Tarun Kanti
[off-list ref] wrote:
On Tue, Mar 13, 2012 at 1:23 AM, DebBarma, Tarun Kanti
[off-list ref] wrote:
quoted
On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman [off-list ref] wrote:
quoted
Tarun Kanti DebBarma [off-list ref] writes:
quoted
The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
as we already have them as part of bank->context now. Also, remove un-used
variable from gpio_irq_handler.
The fixes include correction of _set_gpio_irqenable() implementation,
missing wakeup_en register update in set_gpio_wakeup(), type mismatch
of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
register update in set_gpio_dataout_() and few corrections in context
save logic.
It is baselined on top of Kevin's following series:
gpio/omap: cleanup and runtime PM conversion for v3.4
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/gpio/runtime-pm-cleanup
Series is available here for reference:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev for_3.4/gpio_further_cleanup_fixes
This branch doesn't exist.
Oops... I am sorry.
I was in the process of updating the branch with latest comments after
base-lining on Grant's:
git://git.secretlab.ca/git/linux-2.6.git
Branch: gpio/next
Because this has all the gpio changes including Benoit's latest gpio
devicetree changes.
Should I go ahead?
Anyways, for the time being I am updating on top of your changes as before.
You should be able to see the branch shortly.
Please note that the branch has your following patch:
gpio/omap: fix wakeups on level-triggered GPIOs
--
Tarun