On Thu, Mar 08, 2012 at 12:35:36AM +0000, bill4carson wrote:

On 2012?02?29? 23:38, Catalin Marinas wrote:

quoted

On Wed, Feb 29, 2012 at 11:28:30AM +0000, bill4carson wrote:

quoted

On 2012?02?29? 18:32, Catalin Marinas wrote:

quoted

On Mon, Feb 13, 2012 at 09:44:22AM +0000, Bill Carson wrote:

quoted

+static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
+					   unsigned long addr, pte_t *ptep)
+{
+	pte_t old_pte = *ptep;
+	set_huge_pte_at(mm, addr, ptep, pte_wrprotect(old_pte));
+}

You could use the generic ptep_set_wrprotect()

I'm a bit of confused about this.

generic ptep_set_wrprotect() can not set huge pte, that's why
set_huge_pte_at is used instead here.

Ah, the generic one can only work with with LPAE where set_huge_pte_at()
is just a set_pte_at(). So this part looks good.

Thanks for your time to review PATCH1/7 :)

I'm wondering if reset of this patch set is ok,
I would like to start working on V3 as per your comments.

I haven't finished looking through the patches. Probably I will by the
end of this week.

-- 
Catalin