Thread (30 messages) flat view 30 messages, 6 authors, 2012-03-07
STALE5286d

[PATCH 14/15] watchdog/mpcore_wdt: Add clock framework support

From: viresh kumar <hidden>
Date: 2012-03-07 12:13:57
Also in: linux-watchdog

On 3/7/12, Srinidhi Kasagar [off-list ref] wrote:
On Wed, Mar 07, 2012 at 11:27:55 +0100, Viresh KUMAR wrote:
quoted
+	wdt->boot_status = (readl(wdt->base + TWD_WDOG_RESETSTAT) &
+			TWD_WDOG_RESETSTAT_MASK) ? WDIOF_CARDRESET : 0;
+
I see that patch 12/15 does this, why are you doing it here again in clock
patch?
quoted
-	wdt->boot_status = (readl(wdt->base + TWD_WDOG_RESETSTAT) &
-			TWD_WDOG_RESETSTAT_MASK) ? WDIOF_CARDRESET : 0;
-
oh, you delete this stuff here again.

something messy in patch creation?
Yes. It does look messy. But it was intentional to move this code up
in the function.
Will move clk patch before IOCTL addition patch to make it clean.

--
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help