Thread (26 messages) 26 messages, 2 authors, 2012-03-09
STALE5317d REVIEWED: 1 (0M)

1 review trailer.

[PATCH v3 09/13] gpio/omap: remove suspend/resume callbacks

From: Santosh Shilimkar <hidden>
Date: 2012-03-07 12:01:41
Also in: linux-omap

On Wednesday 07 March 2012 12:15 PM, Tarun Kanti DebBarma wrote:
Both omap_gpio_suspend() and omap_gpio_resume() does programming
of wakeup_en register.
_gpio_rmw(base, bank->regs->wkup_en, 0xffffffff, 0);
_gpio_rmw(base, bank->regs->wkup_en, bank->context.wake_en, 1);

This is redundant in omap_gpio_suspend() because wakeup_en
register automatically gets initialized in _set_gpio_wakeup()
and set_gpio_trigger() while being called either from
chip.irq_set_wake() or chip.irq_set_type().

This is redundant in omap_gpio_resume() because wakeup_en
s/This is/This is also
register is programmed in omap_gpio_restore_context() called
which is called from runtime resume callback.

Signed-off-by: Tarun Kanti DebBarma <redacted>
---
Reviewed-by: Santosh Shilimkar <redacted>

Regards
Santosh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help