On Thu, 2012-03-01 at 12:22 +0530, Rajendra Nayak wrote:

On Wednesday 29 February 2012 07:56 PM, Tero Kristo wrote:

quoted

From: Vishwanath BS<redacted>

Enable IO Wake up for OMAP3 as part of PM Init. Currently this has been
managed in cpuidle path which is not the right place. Subsequent patch
will remove IO Daisy chain handling in cpuidle path once daisy chain is
handled as part of hwmod mux.

Signed-off-by: Vishwanath BS<redacted>
Tested-by: Govindraj.R<redacted>
Signed-off-by: Tero Kristo<redacted>
---
  arch/arm/mach-omap2/pm34xx.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index e97ec3f..e6c2d39 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c

@@ -793,6 +793,10 @@ static int __init omap3_pm_init(void)
  		goto err1;
  	}

+	if (omap3_has_io_wakeup())
+		omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_MASK, WKUP_MOD,
+					   PM_WKEN);

On OMAP4 this GLOBAL IO chain enable happens as part of the trigger
function itself, it might make sense to do that for OMAP3 too to avoid
similar issues as seen on OMAP4 when the GLOBAL switch is enabled too
late in boot. The best however would be to get rid of it in the trigger
function and enable this early during PM init, but I am not sure whats
a good place to do this 'early' enough.

Sounds good. This will take care of the comment from Paul also.

-Tero

regards,
Rajendra

quoted

+
  	ret = pwrdm_for_each(pwrdms_setup, NULL);
  	if (ret) {
  		printk(KERN_ERR "Failed to setup powerdomains\n");