[PATCH 1/5 v3] i2c/gpio: add DT support
From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2012-03-08 16:53:38
Also in:
linux-devicetree, linux-i2c
Possibly related (same subject, not in this thread)
- 2012-03-13 · Re: [PATCH 1/5 v3] i2c/gpio: add DT support · Wolfram Sang <hidden>
- 2012-03-13 · Re: [PATCH 1/5 v3] i2c/gpio: add DT support · Jean-Christophe PLAGNIOL-VILLARD <hidden>
- 2012-03-13 · Re: [PATCH 1/5 v3] i2c/gpio: add DT support · Wolfram Sang <hidden>
- 2012-03-13 · Re: [PATCH 1/5 v3] i2c/gpio: add DT support · Jean-Christophe PLAGNIOL-VILLARD <hidden>
- 2012-03-08 · Re: [PATCH 1/5 v3] i2c/gpio: add DT support · Rob Herring <hidden>
On 11:52 Thu 08 Mar , Karol Lewandowski wrote:
On 08.03.2012 09:50, Jean-Christophe PLAGNIOL-VILLARD wrote:quoted
+static int __devinit of_i2c_gpio_probe(struct device_node *np, + struct i2c_gpio_platform_data *pdata) +{ + u32 reg; + + if (of_gpio_count(np) < 2) + return -ENODEV; + + pdata->sda_pin = of_get_gpio(np, 0); + pdata->scl_pin = of_get_gpio(np, 1); + + if (pdata->sda_pin < 0 || pdata->scl_pin < 0) { + pr_err("%s: invalid GPIO pins, sda=%d/scl=%d\n", + np->full_name, pdata->sda_pin, pdata->scl_pin); + return -ENODEV; + } + + of_property_read_u32(np, "i2c-gpio,delay-us", &pdata->udelay); +quoted
+ if (of_property_read_u32(np, "i2c-gpio,timeout-ms", ®)) + pdata->timeout = msecs_to_jiffies(reg);I've already said (two times!) that of_property_read_u32() returns nonzero (negative) error code on _error_. Don't you see obvious error in above code fragment? You assign to pdata->timeout on _error_.
yeah forget this one Jean can I have you are ack so I send the v4 and the pull today Best Regards, J.