Thread (1 message) 1 message, 1 author, 2012-03-07

[PATCH 14/14] ARM: kirkwood: use devicetree to init sata_mv

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-03-07 19:00:47
Also in: linux-devicetree

On Wednesday 07 March 2012, Jason wrote:
quoted
Is it guaranteed that it's always the first port that gets used if there
is only one? If not, this might turn on the wrong one.
This is the same logic as mach-kirkwood/common.c:176

void __init kirkwood_sata_init(struct mv_sata_platform_data *sata_data)
{
        kirkwood_clk_ctrl |= CGC_SATA0;
        if (sata_data->n_ports > 1)
                kirkwood_clk_ctrl |= CGC_SATA1;

        orion_sata_init(sata_data, SATA_PHYS_BASE, IRQ_KIRKWOOD_SATA);
}

So, I don't think I'm introducing a regression.
Ok, good point. I was wondering whether the individual ports should
be modeled in the device tree, but I guess it's not necessary if nobody
needed this so far.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help