Thread (7 messages) flat view 7 messages, 4 authors, 2012-03-04

[PATCH 4/5 v2] ARM: kirkwood: convert rtc-mv to fdt.

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-03-04 16:50:52
Also in: linux-devicetree

Possibly related (same subject, not in this thread)

On Sunday 04 March 2012, Michael Walle wrote:
quoted
@@ -294,11 +295,17 @@ static int __exit mv_rtc_remove(struct
platform_device *pdev) return 0;
 }

+static struct of_device_id rtc_mv_of_match_table[] = {
+     { .compatible = "marvell,rtc", },
+     {}
+};
+
Isn't here an ifdef CONFIG_OF missing to prevent compiler warnings?
Yes, I guess so. I keep thinking that an __unused attribute would
actually be more helpful here because it lets the compiler automatically
discard the symbol when it's not used, but we still get potential
compiler errors and warnings if something inside of the unused data
is broken.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help