[PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

On Sat, Mar 03, 2012 at 10:08:53AM +0000, Russell King - ARM Linux wrote:

On Fri, Mar 02, 2012 at 06:32:33PM +0000, Arnd Bergmann wrote:

quoted

On Friday 02 March 2012, Jason Cooper wrote:

quoted

+       wdt_reg = (void __iomem *)TIMER_VIRT_BASE;
+
+       ret = of_address_to_resource(np, 0, &res);
+       if (ret) {
+               printk(KERN_ERR "invalid address\n");
+               return ret;
+       }
+
+       wdt_reg = ioremap(res.start, res.end - res.start);
+

This will break non-dt uses because you overwrite the wdt_reg value.

Don't also forget that "res.end - res.start" is also not correct, and
resource_size() should be used to prevent that kind of error.

Russell, thanks for the review.  I'll redo this one and resubmit my
pull-request to Arnd.  I assume that we don't won't this to be a
separate patch as a future bisect could land inbetween this patch and
the fix.

Sorry for the extra work Arnd.

thx,

Jason.