[PATCH 03/12] ARM: at91/USB host: specify and handle properly vbus_pin_active_low
From: Sergei Shtylyov <hidden>
Date: 2012-03-31 21:53:14
Also in:
lkml
Hello. On 29-03-2012 17:27, Nicolas Ferre wrote:
Due to an error while handling vbus_pin_active_low in ohci-at91 driver, the specification of this property was not good in devices/board files.
quoted hunk ↗ jump to hunk
Signed-off-by: Nicolas Ferre<redacted> Acked-by: Jean-Christophe PLAGNIOL-VILLARD<redacted> Cc: stable<redacted> [3.2+] --- arch/arm/mach-at91/at91sam9263_devices.c | 3 ++- arch/arm/mach-at91/at91sam9g45_devices.c | 6 ++++-- arch/arm/mach-at91/board-sam9263ek.c | 1 + arch/arm/mach-at91/board-sam9m10g45ek.c | 1 + 4 files changed, 8 insertions(+), 3 deletions(-)diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c index 53688c4..5cdca89d 100644 --- a/arch/arm/mach-at91/at91sam9263_devices.c +++ b/arch/arm/mach-at91/at91sam9263_devices.c@@ -72,7 +72,8 @@ void __init at91_add_device_usbh(struct at91_usbh_data *data) /* Enable VBus control for UHP ports */ for (i = 0; i< data->ports; i++) { if (gpio_is_valid(data->vbus_pin[i])) - at91_set_gpio_output(data->vbus_pin[i], 0); + at91_set_gpio_output(data->vbus_pin[i], + data->vbus_pin_active_low[i] ^ 0);
Note that XOR with 0 is a nop, left operand doesn't change its value.
WBR, Sergei