[PATCH 1/1] net: phylib: remove the length limitation of mii bus id

On Tue, Mar 20, 2012 at 10:06:57PM +0800, Florian Fainelli wrote:

Hi,

Le 03/20/12 11:53, Dong Aisheng a ?crit :

quoted

On Tue, Mar 20, 2012 at 1:32 AM, Shawn Guo[off-list ref]  wrote:

quoted

On 20 March 2012 12:23, Dong Aisheng[off-list ref]  wrote:

quoted

From: Dong Aisheng<redacted>

When convert to dt, the length of old mii bus id (17 bytes) is not
sufficent to use.
For example, the bus id could be 800f0000.ethernet-1:00 in DT.

This patch removes the bus id length limitation by changing the
bus id to a const char pionter and user could dynamically set the
bus id via kasprintf function call.

Since then no users use MII_BUS_ID_SIZE any more, just remove it.

Signed-off-by: Dong Aisheng<redacted>
---
The simplest way may just change MII_BUS_ID_SIZE to a more bigger size,
but i'm not sure that's gonna be accepted.

The simplest fix has been applied on -next tree as below.

Oh, i missed it, seems my patch covers that change.
But that patch only fixed wrong phy_name buffer length issue.
My patch is totally remove the length limitation of bus id and phy_name
or the bus id name will be truncated if it's longer than MII_BUS_ID_SIZE
which is not a comfortable limitation.

Then just increase the bus id size locally for your driver. Drivers that 
can live with a static allocation are better of using it.

That's the common part, can not change it locally by driver.
Or we can change MII_BUS_ID_SIZE to a more big size in common code,
maybe 30 bytes, but when is the end?

Your patch completely missed testing the return value of kasprintf(), 
and its return value can be NULL, please fix this at least.

Yes, thanks for the reminder.
I will fix it.

Regards
Dong Aisheng