On 03/13/2012 09:35 AM, Rob Herring wrote:

+	ahb at 80080000 {
+		fec at 800f0000 {
Use generic names: ethernet at 800f0000

Generic is good, but consistency is better, IMHO.  grepping existing dts 
files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@"

quoted

+			uart1: uart at 80074000 {

Use generic names: uart1: serial at ...

Same comment here, but unfortunately there is already inconsistency in 
existing files...  25 instances of "serial@" and 35 instances of "uart@"