[PATCH 2/3] led-triggers: use atomic kzalloc during led trigger registering
From: Bryan Wu <hidden>
Date: 2012-03-13 08:51:15
Also in:
lkml
On Tue, Mar 13, 2012 at 3:37 AM, Linus Walleij [off-list ref] wrote:
2012/3/10 Bryan Wu [off-list ref]:quoted
2012/3/8 Uwe Kleine-K?nig [off-list ref]:quoted
On Thu, Mar 08, 2012 at 05:11:02PM +0800, Bryan Wu wrote:quoted
kzalloc might cause sleep and will generate some warning detected by lockdep, when call led_trigger_register_simple on each cpu cores in SMP. This patch fix this.The obvious (and IMHO better) alternative is to call led_trigger_register_simple from non-atomic context. For registering this should be OK, shouldn't it?Thanks Uwe, it's my bad. I think I should not use on_each_cpu() API to run led_trigger_register_simple. on_each_cpu() will disable interrupt.It might have been my mistake even so not your fault ... :-)
No problem, man. I just simply replaced GFP_KERNEL with GFP_ATOMIC without thinking deeper. Best Regards, -- Bryan Wu [off-list ref] Kernel Developer ? ?+86.138-1617-6545 Mobile Canonical Ltd. ? ? ?www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com