Thread (3 messages) 3 messages, 2 authors, 2012-02-29
DORMANTno replies

[PATCH 6/6] ARM: ux500: select I2C for U8500

From: Linus Walleij <hidden>
Date: 2012-02-29 17:06:46

Possibly related (same subject, not in this thread)

On Wed, Feb 29, 2012 at 6:03 PM, Arnd Bergmann [off-list ref] wrote:
I got one more build error when actually disabling CONFIG_I2C on ux500:

arnd at klappe2:~/linux-arm$ make O=obj-arm/ ?ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- -s ?-j3 -k
/git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c: In function 'mop500_uib_i2c_add':
/git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c:74:2: error: implicit declaration of function 'i2c_get_adapter' [-Werror=implicit-function-declaration]
/git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c:81:3: error: implicit declaration of function 'i2c_new_device' [-Werror=implicit-function-declaration]
/git/arnd/linux-arm/arch/arm/mach-ux500/board-mop500-uib.c:121:2: error: implicit declaration of function 'i2c_smbus_xfer' [-Werror=implicit-function-declaration]

I guess those need to be fixed, too. Ideally the API could just
get stubbed out for !CONFIG_I2C, but it might be easier to
conditionally build the code using it.
Hm in this case it's the code probing the board using I2C to figure out if it's
this or that variant.

So selecting this board needs to select I2C and I2C_NOMADIK to work
properly, I'll see if I can reproduce and think of something.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help