On Wed, Feb 29, 2012 at 2:30 AM, Jean Pihet [off-list ref] wrote:

Hi Rob,

On Wed, Feb 29, 2012 at 4:11 AM, Robert Lee [off-list ref] wrote:

quoted

Make necessary changes to implement time keeping and irq enabling
in the core cpuidle code. ?This will allow the removal of these
functionalities from various platform cpuidle implementations whose
timekeeping and irq enabling follows the form in this common code.

Signed-off-by: Robert Lee <redacted>
---
?arch/arm/include/asm/cpuidle.h | ? 14 ++++++
?drivers/cpuidle/cpuidle.c ? ? ?| ? 90 ++++++++++++++++++++++++++++++++--------
?include/linux/cpuidle.h ? ? ? ?| ? 13 ++++++
?3 files changed, 99 insertions(+), 18 deletions(-)
?create mode 100644 arch/arm/include/asm/cpuidle.h

...

quoted

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 59f4261..00b02f5 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c

...

quoted

@@ -110,7 +126,8 @@ int cpuidle_idle_call(void)

? ? ? ? ? ? ? ?dev->states_usage[entered_state].time +=
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?(unsigned long long)dev->last_residency;
? ? ? ? ? ? ? ?dev->states_usage[entered_state].usage++;
- ? ? ? }
+ ? ? ? } else
+ ? ? ? ? ? ? ? dev->last_residency = 0;

Braces are required here, according to the coding style doc.

Thanks.

...

Regards,
Jean