[PATCH] ARM: 3ds_debugboard: Let ethernet be functional again
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2012-02-28 08:27:15
On Mon, Feb 27, 2012 at 11:54:00PM +0000, Mark Brown wrote:
On Mon, Feb 27, 2012 at 06:20:20PM +0100, Sascha Hauer wrote:quoted
I don't know what to do here. Probably the check for value <= 0 should be removed, but then again the description shows:No, zero is intentionally a valid response - it means that the selector is invalid (for example, due to being documented as a reserved value) allowing a non-error return that doesn't provide a voltage. The fixed regulator should be fixed to return an error if it hasn't got a voltage configured.
Hm, you asked me to drop the voltage parameter from the helper function registering a fixed regulator as dummy. When the fixed regulator bails out in this case I can't see how this can be done. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |