Salut Paul,

On 2/21/2012 11:02 PM, Paul Walmsley wrote:

Salut Beno?t,

On Mon, 20 Feb 2012, Cousson, Benoit wrote:

quoted

3.3-rc4 is broken in the DT case because of the serial driver. And it
looks like it is due to this fix.  We cannot rely on pdata anymore in
DT, and in that case it leads to an Oops due to NULL pdata.

Sorry about the breakage.  I agree with the diagnosis.  That code was just
copied from the DMA errata part of the driver, so it will need to be fixed
as well.  Otherwise the same problem will happen when DMA is enabled.

quoted

And then we will have to add the support for all these OMAP custom hooks without pdata.

That's really the key question for the medium- to long-term...

I know you know, I'm always hoping that someone will step up and propose 
some cool idea to fix that :-)

quoted

A basic fix (below) for the moment is to test for valid pdata inside the driver.
I'll repost it properly if you are fine with it.

Looks fine to me, although I'd suggest fixing the DMA workaround path as
well.

Mmm, I've tried to fix every instances of pdata in the code, you think I 
missed some?

I'll check again.

Reviewed-by: Paul Walmsley<paul@pwsan.com>

Thanks,
Benoit