On Thu, Feb 09, 2012 at 02:00:48AM +0100, Marc Zyngier wrote:
On Wed, 8 Feb 2012 15:42:53 -0800, David Brown [off-list ref]
wrote:
quoted
On Wed, Feb 08, 2012 at 12:30:46AM +0000, Marc Zyngier wrote:
quoted
+#ifdef CONFIG_SMP
+#define soc_smp_init_ops(ops) .smp_init_ops = &(ops),
+#define soc_smp_ops(ops) .smp_ops = &(ops),
+extern void soc_smp_ops_register(struct arm_soc_smp_init_ops *,
+ struct arm_soc_smp_ops *);
+#else
+#define soc_smp_init_ops(ops) /* empty */
+#define soc_smp_ops(ops) /* empty */
+#define soc_smp_ops_register(a,b) do {} while(0)
+#endif
I'm not sure if this bothers anyone else, but these macros mess up
editors that know how to indent C code, since the comma ends up inside
the macro. I'm not sure I have a better idea, though.
Emacs seem quite happy when I wrote the code... Shall we re-open the
editor war? ;-)
It is interesting that emacs gets it right (seem to use both emacs and
vi depending on my mood). I guess treating it as a function call
isn't valid C, so either interpretation in an editor is really right.
I guess just leave it. The structs are small, and it isn't too hard
lo fix things up. As I said earlier, I can't think of a better way to
do it.
Davi
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.