[PATCH 06/16] ARM: omap: fix uninformative vc/i2c configuration error message
From: Kevin Hilman <hidden>
Date: 2012-02-08 23:07:05
Also in:
linux-omap
Russell King - ARM Linux [off-list ref] writes:
On my OMAP4 platform, I'm getting this error message repeated several times at boot: omap_vc_i2c_init: I2C config for all channels must match. omap_vc_i2c_init: I2C config for all channels must match. This doesn't help identify what the problem is. Fix this message to be more informative: omap_vc_i2c_init: I2C config for vdd_iva does not match other channels (0). omap_vc_i2c_init: I2C config for vdd_mpu does not match other channels (0). This allows us to identify which voltage domains have a problem, and what the I2C configuration state (a boolean, i2c_high_speed) setting being used actually is. omap4_iva_pmic and omap4_mpu_pmic both have it set true. Signed-off-by: Russell King <redacted>
Acked-by: Kevin Hilman <redacted>
quoted hunk
--- arch/arm/mach-omap2/vc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c index ce45695..ff58dc9 100644 --- a/arch/arm/mach-omap2/vc.c +++ b/arch/arm/mach-omap2/vc.c@@ -265,8 +265,8 @@ static void __init omap_vc_i2c_init(struct voltagedomain *voltdm) if (initialized) { if (voltdm->pmic->i2c_high_speed != i2c_high_speed) - pr_warn("%s: I2C config for all channels must match.", - __func__); + pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).", + __func__, voltdm->name, i2c_high_speed); return; }