Thread (7 messages) 7 messages, 3 authors, 2012-02-07
DORMANTno replies

[PATCH v5] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

From: Wolfram Sang <hidden>
Date: 2012-02-07 15:11:58
Also in: linux-i2c

Hi Barry,
if ACK is not received, an interrupt will be got and related register
status can show this error. that is just a common feature in almost
all i2c controllers? so the naming is confused. i just copied it from
the spec.
Yes, this is common and yes, the naming is confusing :) This is why I
asked if it really does what I believed it does. All is fine, no need
for a change.
the mail webpages and clients really fails to show the difference. i
Not all of them. gmane looks OK both in web-interface and via NNTP.
quoted
quoted
quoted
quoted
+ ? ? siic->irq = platform_get_irq(pdev, 0);
+ ? ? if (siic->irq < 0) {
+ ? ? ? ? ? ? err = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
return the error code here?
out lable will free resources and return error code.
Sorry, I meant the error code you received which is in siic->irq.
ok. err = -ENXIO
err = ssic->irq?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120207/194e1c40/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help