Thread (6 messages) flat view 6 messages, 2 authors, 2012-03-02

[PATCH-V3 0/3] ARM: OMAP4: Remove hardcoded reg-offs for PWRSTCTRL & PWRSTST

From: Hiremath, Vaibhav <hidden>
Date: 2012-02-07 10:56:26
Also in: linux-omap

On Fri, Feb 03, 2012 at 17:13:53, Hiremath, Vaibhav wrote:
This patch series removes the existing hard-coded way of providing
offset to omap4_prminst_xxx API's and instead use offsets
provided in powerdomainsxxxx_data.
Also, hook up AM33XX device support to existing omap4 PRM code.

Background:
==========
PRM module in AM33XX is closer to OMAP4 PRM module, so it complete
sense to reuse all the code from existing OMAP4 implementation.
Having said that, there is a catch here with respect to AM33XX device,

The register offset in PRM module is not consistent
across (crazy IP integration), for example,

PRM_XXX         PWRSTCTRL PWRSTST RSTCTRL RSTST
===============================================
PRM_PER_MOD:    0x0C,     0x08,   0x00,   0x04
PRM_WKUP_MOD:   0x04,     0x08,   0x00,   0x0C
PRM_MPU_MOD:    0x00,     0x04,   0x08,   NA
PRM_DEVICE_MOD: NA,       NA,     0x00,   0x08

So in order to reuse the existing OMAP4 code, we have to add
seperate entry for register offsets, especially
PWRSTCTRL & PWRSTST.

NOTE: Boot tested on AM335x EVM and AM37xEVM

Changes from V2:
	- As per Kevin's comment, created separate prm_base table
	  for am33xx and added __init function for prminst to
	  initialize prm_base table during boot time.
	- Minor comment from Kevin, to add extra line in patch 1/3
Changes from V1:
 	- As per Kevin's comment, patch is split into logical
	  commits for ease of review.
  	- Added specific comment for cpu_is_xxx check order
	  change.


Vaibhav Hiremath (3):
  ARM: OMAP4: Remove hardcoded reg-offs for PWRSTCTRL & PWRSTST
  ARM: OMAP4: prminst: Add boot time __init function for prminst
  ARM: OMAP: am33xx: Hook-up am33xx support to existing prm code
Kevin,

Any comments on this patch-series?

Thanks,
Vaibhav
 arch/arm/mach-omap2/io.c                    |    3 ++
 arch/arm/mach-omap2/omap_hwmod.c            |   44 +++++++++++++++++++--------
 arch/arm/mach-omap2/powerdomain.h           |    4 ++
 arch/arm/mach-omap2/powerdomain44xx.c       |   24 +++++++-------
 arch/arm/mach-omap2/powerdomains44xx_data.c |    9 +++++
 arch/arm/mach-omap2/prcm44xx.h              |    2 +
 arch/arm/mach-omap2/prminst44xx.c           |   35 ++++++++++++++++-----
 arch/arm/mach-omap2/prminst44xx.h           |    2 +-
 8 files changed, 89 insertions(+), 34 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help