[PATCH] pinctrl: delete raw device pointers in pinmux maps
From: Stephen Warren <hidden>
Date: 2012-02-01 17:37:42
Also in:
lkml
Linus Walleij wrote at Wednesday, February 01, 2012 10:24 AM:
After discussion with Mark Brown in an unrelated thread about ADC lookups, it came to my knowledge that the ability to pass a struct device * in the regulator consumers is just a historical artifact, and not really recommended. Since there are no in-kernel users of these pointers, we just kill them right now, before someone starts to use them. Cc: Mark Brown <redacted> Signed-off-by: Linus Walleij <redacted>
I didn't review the code, but just wanted to note that Documentation/pinctrl.txt needs some updates too, e.g. "Pinmux board/machine configuration" says:
As you can see we may have several pin controllers on the system and thus we need to specify which one of them that contain the functions we wish to map. The map can also use struct device * directly, so there is no inherent need to use strings to specify .dev_name or .ctrl_dev_name, these are for the situation where you do not have a handle to the struct device *, for example if they are not yet instantiated or cumbersome to obtain.
I'm fine with that being a separate patch if you want, or squashing together two separate patches. -- nvpublic