On Mon, Jan 30, 2012 at 3:13 PM, Paul Walmsley [off-list ref] wrote:

Clean up a few different parts of omap_set_pwrdm_state():

- Remove a superfluous call to pwrdm_state_switch(). ?Not needed
?unless LOWPOWERSTATECHANGE is used, because the state switch code is
?called by either clkdm_sleep() or clkdm_allow_idle().

Indeed

- Add code to wait for the power state transition in the OMAP4+ low
?power state change. ?This is speculative, so I would particularly
?appreciate feedback on this part.

- Remove a superfluous call to pwrdm_read_pwrst().

- Update variable names to be more meaningful (hopefully) and precise.

- Fix an error path bug that would not place the clockdomain back into
?hardware-supervised idle or sleep mode if the power state could not
?be programmed.

The documentation for this function still needs major improvements;
that's left for a later patch.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <redacted>
Cc: Rajendra Nayak <redacted>
Cc: Santosh Shilimkar <redacted>
Cc: Tero Kristo <redacted>
---

All the changes look fine to me from OMAP4
perspective. Would be good if Tero can try out this
patch and test CORE RET on OMAP4.

Acked-by: Santosh Shilimkar <redacted>

Regards
santosh