Thread (28 messages) flat view 28 messages, 5 authors, 2012-01-19
STALE5317d

[RFC PATCH 03/10] ARM: mc146818rtc: remove unnecessary include of mach/irqs.h

From: Russell King - ARM Linux <hidden>
Date: 2012-01-13 16:52:13
Also in: linux-sh

On Fri, Jan 13, 2012 at 10:34:04AM -0600, Rob Herring wrote:
From: Rob Herring <redacted>

The include of mach/irqs.h isn't needed, so remove it. Compiled CMOS rtc
driver.
I'm not sure how safe this is - there are some drivers using mc146818rtc.h
which get their IRQ via this header file (it's known as RTC_IRQ.)  So we
need to verify that nothing breaks as a result of that definition going
away when this file is included.

It looks like it's just drivers/char/rtc.c, which we don't use anymore
on ARM.  So this should be safe.

It might be worth adding:

#define RTC_IRQ BUILD_BUG_ON(true)

or something like that, to catch any users of it (even though that'll then
cause drivers/char/rtc.c to fail if built on ARM, which it shouldn't be.)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help