Thread (1 message) 1 message, 1 author, 2012-01-10

[PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path

From: Datta, Shubhrajyoti <hidden>
Date: 2012-01-10 06:24:13
Also in: linux-i2c, linux-omap

On Tue, Jan 10, 2012 at 11:53 AM, Datta, Shubhrajyoti
[off-list ref] wrote:


On Fri, Dec 16, 2011 at 2:29 PM, Shubhrajyoti [off-list ref] wrote:
quoted
Ben,

On Friday 16 December 2011 02:10 PM, Paul Walmsley wrote:
quoted
Hi

On Tue, 13 Dec 2011, Shubhrajyoti D wrote:
quoted
- ?The reset in the driver at init is not needed anymore as the
? ?hwmod framework takes care of reseting it.
- ?Reset is removed from omap_i2c_init, which was called
? ?not only during probe, but also after time out and error handling.
? ?device_reset were added in those places to effect the reset.
- ?Earlier the hwmod SYSC settings were over-written in the driver.
? ?Removing the same and letting the hwmod take care of the settings.
- ?Clean up the SYSS_RESETDONE_MASK macro as it is no longer needed.
- ?Clean up the SYSCONFIG SYSC bit definition macros.
- ?Fix the typos in wakeup.

Signed-off-by: Shubhrajyoti D <redacted>
---
?drivers/i2c/busses/i2c-omap.c | ? 83 +++++++++++-----------------------------
?1 files changed, 23 insertions(+), 60 deletions(-)
This patch either needs to be acked by Ben with a note that it's okay for
us to merge through the OMAP tree, or needs to be merged by Ben during the
3.4 merge window, after patches 1-3 have reached the mainline tree.
I agree.
Ben do you have any comments .
If there are no further comments can this be merged also ?
Thanks.
quoted
quoted
- Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help