On Wed, Jan 4, 2012 at 3:39 PM, Stephen Warren [off-list ref] wrote:

Olof Johansson wrote at Thursday, December 22, 2011 5:18 PM:

quoted

This is the first step in making it device-tree aware and get rid of the
in-kernel EMC tables (of which there are none in mainline, thankfully).

quoted

-void tegra_init_emc(const struct tegra_emc_table *table, int table_size)
+static int __devinit tegra_emc_probe(struct platform_device *pdev)
+{

...

quoted

+ ? ? }
+
+ ? ? ? ?res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ ? ? ? ?if (!res) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "missing register base\n");
+ ? ? ? ? ? ? ? ?return -ENOMEM;
+ ? ? ? ?}
+
+ ? ? if (!request_mem_region(res->start, resource_size(res), "tegra_emc")) {

Something is wrong with the indentation there.

quoted

+ ? ? /* Since default max_rate on emc clock is the same as firmware set
+ ? ? ?* it to before booting, raise it up here based on known timings.
+ ? ? ?*/
+
+ ? ? for (i = 0; i < pdata->num_tables; i++)
+ ? ? ? ? ? ? if (pdata->tables[i].rate > max)
+ ? ? ? ? ? ? ? ? ? ? max = pdata->tables[i].rate;
+
+ ? ? c->max_rate = max * 2 * 1000;
+
+ ? ? list_for_each_entry(user, &c->shared_bus_list, u.shared_bus_user.node)
+ ? ? ? ? ? ? user->max_rate = c->max_rate;

Hmm. I guess that works OK for now. Using some kind of accessor might
be nice; I'm not sure how that could be implemented once there's a
common clock framework, and this code can't touch the clock internals.

Oh dear, that code should have been ripped out in the patch I posted.
It is definitely not to be left in there.

We're going to assume that firmware boots the system at maximum
performance so the above shouldn't be needed. I guess I could add a
warning for cases where different operation is detected.


-Olof