Thread (17 messages) flat view 17 messages, 6 authors, 2012-01-06
STALE5353d

[RFC PATCH v2 1/2] cpuidle: Add common init interface and idle functionality

From: Rob Lee <hidden>
Date: 2012-01-04 23:21:47

Mark, thanks again for your review.  Will fix the indention in v3.

On 22 December 2011 12:09, Mark Brown
[off-list ref] wrote:
On Wed, Dec 14, 2011 at 01:02:05AM -0600, Robert Lee wrote:
quoted
The patch adds some cpuidle initialization functionality commonly
duplicated by many platforms. ?The duplicate cpuidle init code of
various platfroms has been consolidated to use this common code
and successfully rebuilt.

Signed-off-by: Robert Lee <redacted>
Reviewed-by: Mark Brown <redacted>

This looks good to me with one small comment:
quoted
+int cpuidle_def_idle(struct cpuidle_device *dev,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct cpuidle_driver *drv, int index) {
+ ? ? cpu_do_idle();
+ ? ? return index;
+}
Odd indentation here.

I'll move my s3c64xx cpuidle code over to this, though I think it'll end
up being an incremental patch as Kukjin just said he'd apply it and it'd
be nice to get the support into 3.3 if we can.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help