On Sun, Jan 1, 2012 at 11:21 PM, Grant Likely [off-list ref] wrote:

On Wed, Dec 28, 2011 at 11:06:02PM -0800, Olof Johansson wrote:

quoted

On Wed, Dec 28, 2011 at 11:01 PM, Stephen Warren [off-list ref] wrote:

quoted

Can we deprecate the Samsung format, and only allow it for that Samsung
device (and allow both there), and require a single format for any other
keyboard?

I'm definitely ok with that. Thomas, Grant, Rob? The code in question
is queued for 3.3, so it hasn't been out in a real release yet.

Adding Kukjin as well since it's getting merged through his tree.

Yeah, I'm okay with that.

BTW, please drop the "compatible" value for this binding. ?This binding
describes a common way of describing key mappings, but it isn't a complete
device binding in and of itself. ?Rather, it is a binding used by other
bindings; and as such no driver should ever bind against it directly. ?The
samsung driver can continue to use the other format if it so desires; there
is no harm in it doing so.

Instead, a driver that expects the binding can just call the
matrix_keyboard_of_fill_keymap() library function without checking
the compatible list.

The main reason I had it there today was to make it easier to do a
versioned binding in case of future revisions, but I guess it's not
worth the hassle.

So, in that case I will move out the fn management out of the common
code as well, and pass in the property name to
matrix_keyboard_of_fill_keymap. That way, the drivers that need to do
a fn-keymap can do so outside of the shared code (and it gets rid of
the FIXME in that case as well). Revised patch in a bit.


-Olof