[RFC PATCH v2 1/9] arm: avoid using on_each_cpu hard coded ret value
From: Russell King - ARM Linux <hidden>
Date: 2012-01-08 16:12:27
Also in:
linux-devicetree, lkml
On Sun, Jan 08, 2012 at 03:32:21PM +0200, Gilad Ben-Yossef wrote:
on_each_cpu always returns a hard coded return code of zero. Removing all tests based on this return value saves run time cycles for compares and code bloat for branches. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Acked-by: Peter Zijlstra <redacted> Reviewed-by: Michal Nazarewicz <redacted> CC: Will Deacon <redacted> CC: Peter Zijlstra <redacted> CC: Paul Mackerras <redacted> CC: Ingo Molnar <redacted> CC: Arnaldo Carvalho de Melo <redacted> CC: Russell King <redacted>
Reviewed-by: Russell King <redacted>
quoted hunk ↗ jump to hunk
CC: Grant Likely <redacted> CC: Rob Herring <redacted> CC: linux-arm-kernel at lists.infradead.org CC: devicetree-discuss at lists.ozlabs.org --- arch/arm/kernel/perf_event.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c index 5bb91bf..6e9acb7 100644 --- a/arch/arm/kernel/perf_event.c +++ b/arch/arm/kernel/perf_event.c@@ -616,7 +616,7 @@ static int __init cpu_pmu_reset(void) { if (cpu_pmu && cpu_pmu->reset) - return on_each_cpu(cpu_pmu->reset, NULL, 1); + on_each_cpu(cpu_pmu->reset, NULL, 1);
There's not much to review here... Thanks.
return 0; } arch_initcall(cpu_pmu_reset); -- 1.7.0.4