Thread (7 messages) flat view 7 messages, 3 authors, 2011-12-09
DORMANTno replies

[PATCH v2 1/2] OMAP2+: DMA: Workaround for invalid source position

From: tony@atomide.com (Tony Lindgren)
Date: 2011-12-09 00:42:01
Also in: linux-omap

* P?ter Ujfalusi [off-list ref] [111129 04:26]:
On Thursday 10 November 2011 15:02:04 Jarkko Nikula wrote:
quoted
On 11/10/2011 02:46 PM, Jarkko Nikula wrote:
quoted
On 11/07/2011 11:33 AM, Peter Ujfalusi wrote:

I think this is enough:

if (unlikely(p->dma_read(CDAC, lch) == 0))
offset = p->dma_read(CSSA, lch);

I suppose offset is ok for normal case as it is already read (twise)
above.
Or actually my proposal could have a race if CDAC changes between CSAC
read and CDAC read. In that case it's better to re-read CSAC as your
patch does after CDAC test and give to both:

Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Tony, have you taken this patch? I failed to find it in the l-o tree...
Sorry for the delay, applying both into fixes-non-critical.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help