On Fri, Dec 23, 2011 at 01:18:51PM +0000, Mark Brown wrote:

On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote:

quoted

The driver get cpu operation point table from device tree cpu0 node,
and adjusts operating points using clk and regulator APIs.

Reviewed-by: Mark Brown <redacted>

Thanks.

but one nit:

quoted

+Required properties in /cpus/cpu at 0:
+- cpu-freqs : cpu frequency points it support, in unit of Hz.
+- cpu-volts : cpu voltages required by the frequency point at the same index,
+	      in unit of uV.
+- trans-latency :  transition_latency, in unit of ns.

trans-latency should really say what latency is being measured (the CPU
core only or the whole operation).

dts only descibe hw info. so the transition latency is for hw.
- trans-latency :  transition latency of HW, in unit of ns.

Thanks
Richard