[RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem
From: Linus Walleij <hidden>
Date: 2011-12-14 22:15:54
Also in:
lkml
From: Linus Walleij <hidden>
Date: 2011-12-14 22:15:54
Also in:
lkml
On Wed, Dec 14, 2011 at 10:11 PM, Sascha Hauer [off-list ref] wrote:
On Thu, Dec 15, 2011 at 12:03:42AM +0800, Dong Aisheng wrote:
quoted
+ ? ? pmx = pinmux_get(&pdev->dev, NULL); + ? ? if (IS_ERR(pmx)) { + ? ? ? ? ? ? err = PTR_ERR(pmx); + ? ? ? ? ? ? goto err_pmx_get; + ? ? } + ? ? err = pinmux_enable(pmx); + ? ? if (err) + ? ? ? ? ? ? goto err_pmx_enable; + ? ? imx_data->pmx = pmx; +Won't this break every i.MX except i.MX6?
Not this patch on its own, first the machines have to select PINCTRL select PINMUX_FOO *Then* it will break :-D So if you want to do this for i.MX you need something like selectable dummy pinmuxes, i.e. pinmux_get() to return something that just say "OK" to everything like the dummy regulators. Shall I try to create something like that? Yours, Linus Walleij