Thread (2 messages) flat view 2 messages, 2 authors, 2011-11-15
DORMANTno replies REVIEWED: 1 (1M)

1 review trailer.

[PATCH] ARM: mmp: encode device id into {pxa168, pxa910, mmp2}_add_*()

From: haojian.zhuang@gmail.com (Haojian Zhuang)
Date: 2011-11-15 11:31:24

On Tue, Nov 15, 2011 at 11:27 AM, Eric Miao [off-list ref] wrote:
Use

?pxa168_add_uart1();

instead of

?pxa168_add_uart(1);

to further eliminate the parameter passing to the function, which
could be error prone, and also making the code a bit simpler and
faster.

Idea came from Russell King.

Cc: Russell King <redacted>
Cc: Haojian Zhuang <redacted>
Signed-off-by: Eric Miao <redacted>
---
?arch/arm/mach-mmp/aspenite.c ? ? ? ? ? ?| ? ?6 +-
?arch/arm/mach-mmp/avengers_lite.c ? ? ? | ? ?2 +-
?arch/arm/mach-mmp/brownstone.c ? ? ? ? ?| ? 10 ++--
?arch/arm/mach-mmp/flint.c ? ? ? ? ? ? ? | ? ?4 +-
?arch/arm/mach-mmp/gplugd.c ? ? ? ? ? ? ?| ? ?6 +-
?arch/arm/mach-mmp/include/mach/mmp2.h ? | ? 70 +++++++++++++-----------------
?arch/arm/mach-mmp/include/mach/pxa168.h | ? 72 +++++++++++-------------------
?arch/arm/mach-mmp/include/mach/pxa910.h | ? 51 ++++++++--------------
?arch/arm/mach-mmp/jasper.c ? ? ? ? ? ? ?| ? ?8 ++--
?arch/arm/mach-mmp/tavorevb.c ? ? ? ? ? ?| ? ?2 +-
?arch/arm/mach-mmp/teton_bga.c ? ? ? ? ? | ? ?4 +-
?arch/arm/mach-mmp/ttc_dkb.c ? ? ? ? ? ? | ? ?4 +-
?12 files changed, 100 insertions(+), 139 deletions(-)
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help