Thread (19 messages) read the whole thread 19 messages, 8 authors, 2011-11-22
STALE5368d

Revision v1 of 7 in this series.

Revisions (7)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v1 current
  6. v1 [diff vs current]
  7. v1 [diff vs current]

[PATCH 1/4] arm/imx: fix mx3_defconfig to add FEC back

From: Uwe Kleine-König <hidden>
Date: 2011-11-11 10:12:51

On Fri, Nov 11, 2011 at 03:16:25PM +0800, Shawn Guo wrote:
On Thu, Nov 10, 2011 at 09:57:48AM +0100, Uwe Kleine-K?nig wrote:
quoted
On Thu, Nov 10, 2011 at 04:39:29PM +0800, Shawn Guo wrote:
quoted
The commit 'd880db0 arm: mx3: update defconfig' removes FEC support
which is not good, since FEC is useful for both developers and users.
$ git show d880db0^:drivers/net/Kconfig | grep -A4 'config FEC$'
config FEC
	bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
	depends on M523x || M527x || M5272 || M528x || M520x || M532x || \
		IMX_HAVE_PLATFORM_FEC || MXS_HAVE_PLATFORM_FEC
	default IMX_HAVE_PLATFORM_FEC || MXS_HAVE_PLATFORM_FEC if ARM

So when d880db0 was created

	make savedefconfig

dropped CONFIG_FEC=y justifiably. The culprit is commit

	230dec6 (net/fec: add imx6q enet support)

which dropped the default line.
Thanks for letting me know that's me :)
:-)

I forgot to say that I prefer to add back the default line in Kconfig
instead of adding it to the defconfig again.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help