[PATCH 2/5] dma i.MX: remove individual SOC dependency
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2011-11-09 11:27:34
On Tue, Nov 08, 2011 at 09:42:56PM +0100, Micha? Miros?aw wrote:
2011/8/24 Sascha Hauer [off-list ref]:quoted
The individual SoC dependency in Kconfig hardly scales anymore. Instead of having such a fine grained dependency just depend on ARCH_MXC and risk that the uninformed user has to look in the help text to figure out which driver is the correct one.[...]quoted
?config MX3_IPU ? ? ? ?bool "MX3x Image Processing Unit support" - ? ? ? depends on ARCH_MX3 + ? ? ? depends on ARCH_MXC ? ? ? ?select DMA_ENGINE ? ? ? ?default y ? ? ? ?helpYou could instead make it depend on HAVE_MX3_IPU and select this symbol from relevant model config. Leaving it for the users is making every one of them redo the work you already did.
I thought about this. I came to the conclusion that these are quite hard to change when they are present in many subsystems (I try to get rid of ARCH_MXx macros for some time now). Also with upcoming devicetree support the IMX_HAVE_ macros will loose their meaning anyway. Being a bit more relaxed with the 'depends on' only means that a user might compile in some unused drivers, which is the standard case on other architectures like x86 anyway. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |