Thread (1 message) 1 message, 1 author, 2011-11-22

[PATCH 5/5] arm/dt: tegra: Fix SDHCI nodes to match board files

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2011-11-22 16:23:38
Also in: linux-devicetree, linux-tegra

On 08:12 Tue 22 Nov     , Stephen Warren wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote at Tuesday, November 22, 2011 1:38 AM:
quoted
On 14:44 Mon 21 Nov     , Stephen Warren wrote:
quoted
Mark any SDHCI controllers that aren't registered by the board files as
disabled in the device-tree files.

In practice, these controllers:

* Have nothing hooked up to them at all, or
* For ports intended for SDIO usage, the drivers for anything that might
  be attached are not in the device-tree yet. If/when drivers appear, the
  SD/MMC port can be re-enabled.

The only possible exception is TrimSlice's mico SD slot, but that wasn't
enabled in the board files before anyway, and doesn't work when all the
SDHCI controllers are enabled anyway.
it will be better to invert the logic

just enable what you are supposed too
It used to be that way when the files were first added, but they got
switched around this way to match standard practice.
this is a bad practice because you can enable stuff that a hardware is not
supposed to use

and this silenty without anyone notice until you test the hardware

and you add more line and changeset

Best Regrds,
J.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help