Hi Grant,

On 8 November 2011 02:47, Grant Likely [off-list ref] wrote:

On Thu, Nov 03, 2011 at 02:06:03AM +0530, Thomas Abraham wrote:

quoted

Add device tree based discovery support for Samsung's sdhci controller

Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Thomas Abraham <redacted>
---
+Example:
+ ? ? sdhci at 12530000 {
+ ? ? ? ? ? ? compatible = "samsung,exynos4210-sdhci";
+ ? ? ? ? ? ? reg = <0x12530000 0x100>;
+ ? ? ? ? ? ? interrupts = <139>;
+ ? ? ? ? ? ? samsung,sdhci-bus-width = <4>;
+ ? ? ? ? ? ? linux,mmc_cap_4_bit_data;

Following on from my reply on patch 5, this is an example of exactly
what I'm talking about. ?This node both sets bus-width to '4', and
sets the 4_bit_data flag. ?Don't you think that the driver would be
smart enough to set the 4_bit_data flag when the bus width was set to
4?

Yes, that is true. I will modify the driver based on your comments and
resubmit this patch.

Thanks for your comments.

Regards,
Thomas.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html