Thread (32 messages) 32 messages, 5 authors, 2011-11-23

[PATCH 08/10] arm/tegra: pinmux tables and definitions for tegra30

From: Stephen Warren <hidden>
Date: 2011-11-18 21:51:29
Also in: linux-devicetree, linux-tegra, lkml

Olof Johansson wrote at Friday, November 18, 2011 2:43 PM:
quoted
@@ -667,7 +710,12 @@ void tegra_pinmux_config_pullupdown_table(const struct tegra_pingroup_config *co
 }

 static struct of_device_id tegra_pinmux_of_match[] __devinitdata = {
+#ifdef CONFIG_ARCH_TEGRA_2x_SOC
 	{ .compatible = "nvidia,tegra20-pinmux", tegra20_pinmux_init },
+#endif
+#ifdef CONFIG_ARCH_TEGRA_3x_SOC
+	{ .compatible = "nvidia,tegra30-pinmux", tegra30_pinmux_init },
+#endif
Again, provide empty stubs instead of ifdeffing the table.
Isn't it better for the driver not to support that compatible flag, rather
than claiming support, but then not actually working correctly?

-- 
nvpublic
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help