On Sun, Nov 13, 2011 at 8:59 PM, Shawn Guo [off-list ref] wrote:

Hi Grant,

On Tue, Nov 08, 2011 at 06:19:38PM -0700, Grant Likely wrote:
[...]

quoted

diff --git a/include/linux/of.h b/include/linux/of.h
index 4948552..566deab 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h

@@ -222,6 +222,13 @@ extern const void *of_get_property(const struct device_node *node,

?#define for_each_property(pp, properties) \
? ? ? for (pp = properties; pp != NULL; pp = pp->next)

+#define MAX_PHANDLE_ARGS 8
+struct of_phandle_args {
+ ? ? struct device_node *np;
+ ? ? int args_count;
+ ? ? uint32_t args[MAX_PHANDLE_ARGS];
+};
+

I'm seeing a bunch of warnings like the one below when compiling imx
with the series. ?And moving the definition to somewhere before
'#include <asm/prom.h>' in linux/of.h removes the warnings for me.

?CC ? ? ?arch/arm/kernel/devtree.o
In file included from arch/arm/plat-mxc/include/mach/irqs.h:14:0,
? ? ? ? ? ? ? ? from arch/arm/include/asm/irq.h:4,
? ? ? ? ? ? ? ? from arch/arm/include/asm/prom.h:17,
? ? ? ? ? ? ? ? from include/linux/of.h:133,
? ? ? ? ? ? ? ? from arch/arm/kernel/devtree.c:17:
include/asm-generic/gpio.h:133:24: warning: ?struct of_phandle_args? declared inside parameter list
include/asm-generic/gpio.h:133:24: warning: its scope is only this definition or declaration, which is probably not what you want

Fixed, thanks.

g.