Thread (10 messages) read the whole thread 10 messages, 3 authors, 2011-12-05

[PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960

From: nico@fluxnic.net (Nicolas Pitre)
Date: 2011-11-08 19:09:05
Also in: linux-arm-msm, lkml

On Tue, 8 Nov 2011, Stephen Boyd wrote:
Add support for DEBUG_LL on the 8660 and 8960 development boards.
While we're here cleanup the uncompress.h code a bit. Avoid
the use of readl/writel as those are Linux specific APIs that
aren't guaranteed to work in the decompressor.

Cc: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: Stephen Boyd <redacted>
Acked-by: Nicolas Pitre <redacted>

Independently from this patch, I was wondering about this code:
+	.macro	senduart, rd, rx
+#ifdef CONFIG_MSM_HAS_DEBUG_UART_HS
+	@ Write the 1 character to UARTDM_TF
+	str	\rd, [\rx, #0x70]
+#else
 	teq	\rx, #0
 	strne	\rd, [\rx, #0x0C]
+#endif
 	.endm
Why testing for zero in the #else part?  The upper level code should 
never call this macro with a null byte.


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help