Thread (26 messages) 26 messages, 11 authors, 2011-11-14

[PATCH] RS485: fix inconsistencies in the meaning of some variables

From: jesper.nilsson@axis.com (Jesper Nilsson)
Date: 2011-11-08 16:34:53
Also in: linux-serial, lkml

On Tue, Nov 08, 2011 at 04:45:46PM +0100, Claudio Scordino wrote:
Subject: RS485: fix inconsistencies in the meaning of some variables
From: Claudio Scordino <redacted>

The crisv10.c and the atmel_serial.c serial drivers intepret the fields of the
serial_rs485 structure in a different way.
In particular, crisv10.c uses SER_RS485_RTS_AFTER_SEND and
SER_RS485_RTS_ON_SEND for the voltage of the RTS pin; atmel_serial.c, instead,
uses these values to know if a delay must be set before and after sending.
This patch makes the usage of these variables consistent across all drivers and
fixes the Documentation as well.
quoted
From now on, SER_RS485_RTS_AFTER_SEND and SER_RS485_RTS_ON_SEND will be used to
set the voltage of the RTS pin (as in the crisv10.c driver); the delay will be
understood by looking only at the value of delay_rts_before_send and
delay_rts_after_send.

Signed-off-by: Claudio Scordino <redacted>
Signed-off-by: Darron Black <redacted>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson at axis.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help