On Tue, Nov 01, 2011 at 07:06:56PM +0100, Michal Nazarewicz wrote:

quoted

page_isolation.c may also be a better fit than page_alloc.c

Since isolate_freepages_block() is the only user of split_free_page(),
would it make sense to move split_free_page() to page_isolation.c as
well?  I sort of like the idea of making it static and removing from
header file.

I see no problem with that. It'll be separate from split_page() but that
is not earth shattering.

Thanks.

-- 
Mel Gorman
SUSE Labs